Stamp every log line, including captured script output - #10
Merged
Conversation
A script's stdout and stderr were logged as one DEBUG record with embedded newlines, so every line after the first landed in the file without a stamp or level. The writer now emits one stamped record per non-blank line of any message, and captured output is logged per line as "[OUTPUT] <script>: line", stdout at INFO and stderr at WARN, so a reader can tell the tool's own lines from what it ran and nothing in the file is ever unstamped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script's stdout and stderr were logged as one DEBUG record with embedded newlines, so every line after the first landed in the file without a stamp or level. The writer now emits one stamped record per non-blank line of any message, and captured output is logged per line as
[OUTPUT] <script>: line, stdout at INFO and stderr at WARN. Tests cover the line splitting and the tagging.