Skip to content

fix(kv): Composed-1 verifyOwnerFromSnapshot must routeKey-normalize before OwnerOf (issue #930) #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bootjp wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(kv): Composed-1 verifyOwnerFromSnapshot must routeKey-normalize before OwnerOf (issue #930) #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion kv/fsm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,20 @@ func (f *kvFSM) verifyOwnerFromSnapshot(mutations []*pb.Mutation, snap RouteSnap
if isTxnInternalKey(mut.Key) {
continue
}
owner, found := snap.OwnerOf(mut.Key)
// Issue #930 fix: normalize the raw mutation key through
// routeKey() before consulting OwnerOf — the same way
// ShardRouter.ResolveGroup and ShardStore.GetAt route on the
// engine side. Without this, raw adapter keys (e.g.
// "!ddb|meta|table|<base64>") are compared byte-wise against
// routing keys (e.g. "!ddb|route|table|<base64>") which sit in
// a completely different lexicographical band, yielding a
// wrong-group verdict and a spurious ErrComposed1Violation on
// every adapter write. Reproduced by PR #911-#925 M5a
// multi-table workload: every DynamoDB CreateTable / write to
// a group-2 table was rejected because OwnerOf saw the raw
// "!ddb|meta|..." key fall into group 1 instead of the routing
// key's actual group-2 range.
owner, found := snap.OwnerOf(routeKey(mut.Key))
if !found || owner != f.shardGroupID {
return errors.Wrapf(ErrComposed1Violation,
"%s-version v=%d: key %q owned by group %d (found=%v); this FSM serves group %d",
Expand Down
Loading