ephemeral: Fix boot for images without virtiofs dracut module#273
Open
cgwalters wants to merge 1 commit into
Open
ephemeral: Fix boot for images without virtiofs dracut module#273cgwalters wants to merge 1 commit into
cgwalters wants to merge 1 commit into
Conversation
Some images don't have the dracut virtiofs module enabled. It's tiny, and they probably *should*, but...on the other hand since we already inject other content into the initramfs here, we can just change things so instead of injecting kargs, we just inject a trivial unit into the initramfs - no dracut involved or needed. Assisted-by: OpenCode (Claude Sonnet 4.6) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the ephemeral boot process by replacing kernel command-line root parameters with an injected systemd mount unit. It adds a sysroot.mount file and a drop-in configuration to the CPIO archive, ensuring the virtiofs root is mounted correctly by systemd. The kernel command-line construction is updated to omit root=, rootfstype=, and rootflags= to defer mounting to systemd. Feedback was provided to optimize the test suite by reading file contents only for specific entries being verified, rather than for every entry in the CPIO archive, which currently causes unnecessary I/O and memory allocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some images don't have the dracut virtiofs module enabled. It's tiny, and they probably should, but...on the other hand since we already inject other content into the initramfs here, we can just change things so instead of injecting kargs, we just inject a trivial unit into the initramfs - no dracut involved or needed.
Assisted-by: OpenCode (Claude Sonnet 4.6)