Make basic_static_string usable as a NTTP (new PR from PR 56)#79
Merged
gennaroprota merged 8 commits intodevelopfrom Dec 19, 2025
Merged
Make basic_static_string usable as a NTTP (new PR from PR 56)#79gennaroprota merged 8 commits intodevelopfrom
basic_static_string usable as a NTTP (new PR from PR 56)#79gennaroprota merged 8 commits intodevelopfrom
Conversation
gennaroprota
force-pushed
the
pr-56
branch
16 times, most recently
from
154cd9c to
329e5e0
Compare
GCC 5-10 incorrectly complain about our nested classes being private. So, make them public.
…r one Reason: See the new code comment.
Reason: They have the same issue as GCC 9.
They were conditioned on detection of C++20 via __cplusplus, but Clang 10 and 11 don't support class types as NTTP, even though they report C++20 via __cplusplus when -std=c++20 is used.
The iterator-based insert(const_iterator, size_type, value_type)
function relies on traits_type::move() to shift the existing null
terminator to its new position. Clang 3.7's constexpr evaluator does not
handle this correctly, causing the following test to fail:
static_string<3>{"ab"}.insert(2, 1, 'c') == "abc"
Add an explicit term() call, guarded by a preprocessor conditional for
Clang 3.7, to ensure proper null termination.
gennaroprota
force-pushed
the
pr-56
branch
2 times, most recently
from
cb23a72 to
3211456
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.