You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ultimately, for PEP-384 (CPython 3.2+) someone who understands the output needs to run abitype.py[1] against src/object/enum.cpp and src/object/class.cpp. The slot/spec layouts[2] generated by that code are pretty close to right, but need someone more fluent in this than I....
This PR gets the other helpers in place for staying to the stricter ABI.
I'm really unsure what the changes from abitype.py mean for the overall usage and behaviour of the library. To be honest, I'm not much of a C++ programmer and can't meaningfully assess that output. All I know is it doesn't compile without help. I honestly don't understand that section of the code in any real way.
I'm not entirely sure I understand the purpose of this PR. As far as I can see, all it does is to replace non-checking functions by their checking counter parts, thereby making the code overall slower. (Example: PyTuple_GET_SIZE is replaced by PyTuple_Size, PyTuple_GET_ITEM is replaced by PyTuple_GetItem, etc.)
Am I missing something ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimately, for PEP-384 (CPython 3.2+) someone who understands the output needs to run
abitype.py[1] againstsrc/object/enum.cppandsrc/object/class.cpp. The slot/spec layouts[2] generated by that code are pretty close to right, but need someone more fluent in this than I....This PR gets the other helpers in place for staying to the stricter ABI.
[1]
https://github.com/python/cpython/blob/master/Tools/scripts/abitype.py
[2]
https://pythoncapi.readthedocs.io/type_object.html#pytype-fromspec