Open
Conversation
include/boost/python/set.hpp
Outdated
| #include <boost/python/ssize_t.hpp> | ||
|
|
||
| namespace boost { | ||
| namespace python { |
Member
There was a problem hiding this comment.
please reformat the patch to use two spaces as indentation, rather than eight.
Author
There was a problem hiding this comment.
I think all the mentioned issues are resolved now
Member
|
Given the similarities with other Python types, perhaps you can guess what build logic needs to be added ? (Have a look at |
Member
|
There are still a few pieces of build infrastructure missing:
|
Author
|
done, Thanks for the guidance |
lightmare
reviewed
Dec 5, 2019
| } | ||
| else | ||
| { | ||
| this->attr("discrad")(x); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.