You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this solves #971 while keeping the class immutable like @NAThompson wants. Since this header requires C++17 guaranteed copy elision should make passing the data from the class to the user through the free function inexpensive. @Tomaqa I used your use case as the additional test case.
It is a way.
However, I need to convert the resulting coefficients back to a rational or floating-point number.
It can again be achieved by a free function which operates upon a vector of coefficients, but I think it is not conceptual. I just want to convert the resulting simple_continued_fraction to rational.
A possible way is to add constructor simple_continued_fraction(std::vector<> coefficients) where the coefficients will be checked whether they are valid, which should be easy to implement and inexpensive to run.
Also, std::move can be used.
If this idea is fine with you, I can implement it, but I will need to use your commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this solves #971 while keeping the class immutable like @NAThompson wants. Since this header requires C++17 guaranteed copy elision should make passing the data from the class to the user through the free function inexpensive. @Tomaqa I used your use case as the additional test case.