Adapt bimaps::relation::structured_pair, container::detail::pair, and compressed_pair#196
Open
CromwellEnage wants to merge 2 commits intoboostorg:developfrom
Open
Adapt bimaps::relation::structured_pair, container::detail::pair, and compressed_pair#196CromwellEnage wants to merge 2 commits intoboostorg:developfrom
CromwellEnage wants to merge 2 commits intoboostorg:developfrom
Conversation
… compressed_pair Recognize boost::bimaps::relation::structured_pair, boost::container::detail::pair, and boost::compressed_pair as Fusion sequences.
Added documentation for newly adapted Fusion sequences bimaps::relation::structured_pair, compressed_pair, and container::detail::pair.
Collaborator
|
Awesome! |
Collaborator
|
I suppose it makes sense to merge this. I have a request though: would you take care of support related issues related to these additions? |
djowel
requested changes
Oct 6, 2020
| Distributed under the Boost Software License, Version 1.0. | ||
| (See accompanying file LICENSE_1_0.txt or copy at | ||
| http://www.boost.org/LICENSE_1_0.txt) | ||
| ============================================================================*/ |
| #include <boost/fusion/adapted/boost_tuple.hpp> | ||
| #include <boost/fusion/adapted/mpl.hpp> | ||
| #include <boost/fusion/adapted/std_pair.hpp> | ||
| #include <boost/fusion/adapted/boost_bimap_pair.hpp> |
Collaborator
There was a problem hiding this comment.
Thinking about it some more, perhaps it's good to have a preprocessor define for bringing these in? Perhaps initially undefined. E.g. BOOST_FUSION_ADAPT_BIMAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize boost::bimaps::relation::structured_pair, boost::container::detail::pair, and boost::compressed_pair as Fusion sequences.