Open
Conversation
Collaborator
|
Why didn't this run all the CI tests? :| |
Author
|
@jeking3 I turned on CI runs on my fork initially, so github decided not to run tests again, when the pull request was made. So the lack of CI runs is not caused by changes. Now I turned off tests in my fork and reran CI. appveyor CI succeded. Github CI now has a requirement of approval from a maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++11is now a minimal required C++ version forboost::format. This means that oldgccversion (older thengcc 4.x) support is no longer required. This PR removes unused workaround forstd::char_traitsandstd::allocator, which was made forgcc2.95.