Add reproducer for Clang < 15 bug with string_view & C++11 char types#186
Open
Flamefire wants to merge 1 commit intoboostorg:developfrom
Open
Add reproducer for Clang < 15 bug with string_view & C++11 char types#186Flamefire wants to merge 1 commit intoboostorg:developfrom
Flamefire wants to merge 1 commit intoboostorg:developfrom
Conversation
Member
|
I see no CI failures for Clang 13/14 here. |
Contributor
Author
|
Seems using libstdc++ 12 and up requires Clang 15. Using libstdc++ 11 works also locally. I'd say the test still makes sense to find potential regressions with the unicode char types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the test case for #185 to reproduce the issue such that it can be verified that it works. Made as a separate PR so CI runs and the state for the commit gets shown.
As explained in #185 converting this string_view to a std string the bug is triggered too but cannot be fixed without removing the conversion to
std::basic_string_view. Hence the condition to exclude it in Clang < 15