Conversation
|
An automated preview of the documentation is available at https://3058.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-09-09 09:45:10 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3058 +/- ##
===========================================
- Coverage 93.30% 93.27% -0.03%
===========================================
Files 177 177
Lines 13764 13764
===========================================
- Hits 12843 12839 -4
- Misses 921 925 +4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Thank you. Could you please check the |
|
This is great! |
24c3156 to
8b0bb38
Compare
|
Thank you @ashtum for the review! I've updated the PR to:
|
8b0bb38 to
629d37d
Compare
|
Thank you for the detailed review! I've addressed all the feedback:
|
|
Fixed all remaining comment alignment issues. |
|
@ssam18 You can use the GitHub Action CI in your own fork to address the compile errors, since it won’t require approval to run each time. |
Use fully qualified boost::core::string_view instead of core::string_view or beast::string_view to ensure correct namespace resolution in nested boost::beast namespace contexts. This fixes compilation errors across all platforms where the compiler was looking for non-existent types like boost::beast::core::string_view. Fixes CI compilation failures in PR boostorg#3058.
|
Why the core::string_view → boost::core::string_view change is necessary? The issue: C++ namespace lookup rules mean that when you write core::string_view in a file, the compiler searches for core starting from the current namespace and working outward. This works fine in files already inside namespace boost { ... } because the compiler finds boost::core. But in standalone example and test files that aren't wrapped in the boost namespace, the compiler can't find core at all. FIX: Files need to use the fully qualified name boost::core::string_view unless they're already inside the boost namespace. This is why: Example files (like example/http/server/async/http_server_async.cpp) → Need boost::core::string_view (standalone programs) |
|
@ashtum Please let me know if this PR looks good? |
All files under For example: namespace beast = boost::beast; // from <boost/beast.hpp>
namespace http = beast::http; // from <boost/beast/http.hpp>
namespace websocket = beast::websocket; // from <boost/beast/websocket.hpp>
namespace net = boost::asio; // from <boost/asio.hpp>
namespace ssl = boost::asio::ssl; // from <boost/asio/ssl.hpp>
namespace core = boost::core; // from <boost/core/detail/string_view.hpp>
using tcp = boost::asio::ip::tcp; // from <boost/asio/ip/tcp.hpp>Please review each changed line manually and use your judgment to fix any formatting, clarity, or semantic issues. |
Use fully qualified boost::core::string_view instead of core::string_view or beast::string_view to ensure correct namespace resolution in nested boost::beast namespace contexts. This fixes compilation errors across all platforms where the compiler was looking for non-existent types like boost::beast::core::string_view. Fixes CI compilation failures in PR boostorg#3058.
987e58b to
a0031df
Compare
Use fully qualified boost::core::string_view instead of core::string_view or beast::string_view to ensure correct namespace resolution in nested boost::beast namespace contexts. This fixes compilation errors across all platforms where the compiler was looking for non-existent types like boost::beast::core::string_view. Fixes CI compilation failures in PR boostorg#3058.
a0031df to
48130a7
Compare
|
@vinniefalco vinniefalco after a long chase, I was able to fix all the failing tests after addressing the review comments. Please take a look at this PR. |
|
@ashtum please review this PR. This has been pending over months. |
|
@ssam18 Thanks for the effort here. After four rounds of reviews, there are still open issues (comment alignment in the doc snippets, redundant |
e24d98a to
91ce221
Compare
The library now spells the type as core::string_view directly, rather than going through the beast::string_view alias. Standalone translation units that need one get a namespace core = boost::core alias. The beast::string_view and beast::basic_string_view aliases are retained as deprecated for compatibility with existing code. Co-authored-by: Samaresh Kumar Singh <ssam3003@gmail.com>
91ce221 to
3a47493
Compare
This PR addresses issue #3046 by replacing all uses of the
string_viewalias withcore::string_viewthroughout the codebase for improved clarity in both documentation and source code.Changes
string_viewwithcore::string_viewin all header files (.hpp)string_viewwithcore::string_viewin all inline implementation files (.ipp)core::string_viewbasic_string_viewwithcore::basic_string_viewwhere applicablestring_type.hppfor backward compatibilityBenefits
boost::core::string_viewFiles Modified
Closes #3046