build: verification-metadata.xml#127
Open
boolivar wants to merge 4 commits into
Open
Conversation
Review Summary by QodoAdd Gradle verification metadata configuration
WalkthroughsDescription• Add Gradle verification metadata configuration file • Enable dependency verification and checksum validation • Support secure build artifact verification Diagramflowchart LR
A["Build Configuration"] -- "adds verification rules" --> B["verification-metadata.xml"]
B -- "enables" --> C["Dependency Verification"]
C -- "validates" --> D["Build Security"]
File Changes1. gradle/verification-metadata.xml
|
Code Review by Qodo
1. Ignored keys reduce security
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+4
to
+36
| <verify-metadata>true</verify-metadata> | ||
| <verify-signatures>true</verify-signatures> | ||
| <ignored-keys> | ||
| <ignored-key id="09A79E1E15A04694" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="0CC0B712FEE75827" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="153E7A3C2B4E5118" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="164779204E106A76" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="218FA0F6A941A037" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="21A24B3F8B0F594A" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="2E55C136C4729D19" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="32AC66C4FBF15ECB" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="3D12CA2AC19F3181" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="3D5839A2262CBBFB" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="47933D17F199636B" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="56E73BA9A0B592D0" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="63F1DD7753B8B315" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="6601E5C08DCCBB96" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="6A0975F8B1127B83" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="6ED0F678B90EB06E" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="72475FD306B9CAB7" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="7A01B0F236E5430F" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="7C7D8456294423BA" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="A6EA2E2BF22E0543" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="BAC30622339994C4" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="BCF4173966770193" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="BFFC9B54721244AD" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="C71FB765CD9DE313" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="DEE12B9896F97E34" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="F13D3E721D56BD54" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="F2A01147D830C125" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="F3D1600878E85A3D" reason="Key couldn't be downloaded from any key server"/> | ||
| <ignored-key id="F4CABFB5B89B8BE6" reason="Key couldn't be downloaded from any key server"/> | ||
| </ignored-keys> |
There was a problem hiding this comment.
1. Ignored keys reduce security 🐞 Bug ⛨ Security
Signature verification is enabled but many signing keys are explicitly ignored because they couldn’t be downloaded. This weakens dependency signature verification (those signatures will be skipped) and suggests key retrieval problems are expected/recurring in clean CI/dev environments.
Agent Prompt
### Issue description
`gradle/verification-metadata.xml` enables signature verification but lists many ignored keys with reason "Key couldn't be downloaded from any key server". This undermines the intended security guarantees and can hide problems with key retrieval.
### Issue Context
Gradle will use `gradle/verification-metadata.xml` automatically for dependency verification. With `verify-signatures=true`, builds may attempt PGP verification, but ignored keys mean some signatures won’t be validated as intended.
### Fix Focus Areas
- gradle/verification-metadata.xml[4-36]
- (If choosing to keep signature verification) add/build documentation or Gradle settings to ensure key retrieval works consistently in CI (e.g., configured key servers or a checked-in keyring).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+256
to
+260
| <component group="com.google.guava" name="guava-parent" version="26.0-android"> | ||
| <artifact name="guava-parent-26.0-android.pom"> | ||
| <pgp value="694621A7227D8D5289699830ABE9F3126BB741C1"/> | ||
| </artifact> | ||
| </component> |
There was a problem hiding this comment.
2. Pgp-only artifacts brittle 🐞 Bug ⛯ Reliability
Some artifacts in the verification metadata are verified only via PGP (no sha256 checksum). With verify-signatures=true, this makes builds brittle: if signature/key retrieval fails (which already occurred for other components), there’s no checksum fallback for these artifacts.
Agent Prompt
### Issue description
Several artifacts in `gradle/verification-metadata.xml` are PGP-only (no sha256). With `verify-signatures=true`, verification depends on PGP signature + key retrieval, which can fail in CI or restricted networks.
### Issue Context
The same metadata records key download failures for other dependencies, so relying exclusively on PGP for some artifacts is risky.
### Fix Focus Areas
- gradle/verification-metadata.xml[4-6]
- gradle/verification-metadata.xml[256-260]
- gradle/verification-metadata.xml[540-544]
- gradle/verification-metadata.xml[612-616]
- gradle/verification-metadata.xml[241-244]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
boolivar
force-pushed
the
verification-metadata
branch
from
cf0c2de to
6982b02
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage 90.35% 90.35%
Complexity 172 172
=========================================
Files 36 36
Lines 477 477
Branches 21 21
=========================================
Hits 431 431
Misses 39 39
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generated verification-metadata.xml