Repository navigation
Web chunk(): build the blank signature inside the call, not at import - #79
Merged
Merged
Conversation
The module-level '0'.repeat(64) is a call the bundler cannot prove pure, so a bundle that imported only getAuthHeaders from the WebCrypto entry still carried it: 5,257 bytes minified, against 5,235 in 1.0.4. Built inside chunk(), the bundle is back to 5,235 and no longer holds the constant. Behavior is unchanged.
bompus
added
author:anthropic
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/in/5532859?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebCrypto entry's module-level
'0'.repeat(64)is a call a bundler cannot prove pure, so a bundle that imported onlygetAuthHeadersstill carried it: 5,257 bytes minified in 1.0.5, against 5,235 in 1.0.4. It is now built insidechunk(), and the same bundle is 5,235 bytes again with norepeat(64)in it. Behavior is unchanged.bun run checkandbun test test/pass.bench/results/tiers.jsonand the web size indocs/benchmarks.mdstill describe the published 1.0.5; the next release re-measures them.