Repository navigation
Re-vendor the unit observer from house-rules at a4f8dd4 - #77
Merged
Merged
Conversation
Brings in the fixes made there since e2a593e: per-sample read timing so a stall in the final sample is caught, a missing pswpout counter fails a storage phase, budgets are compared before rounding, and limits can be set by flags. The file is the house-rules copy with sigflint's two header lines naming the new source commit; nothing else is adapted.
A dated note says which observer the 1.0.4 campaign ran (the e2a593e copy, still in git history at the freeze commit) and what the new copy does differently, so the protocol's statement about frozen code is not read as covering the file now in the tree. No result or frozen record is edited.
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/in/5532859?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bench/observe-unit.pyis a copy of house-rules' unit observer. It was ate2a593e; this replaces it with the copy ata4f8dd4. The file is byte-identical to the source apart from sigflint's two header lines, which now name the new commit. Nothing else is adapted.What the newer observer changes: it times the reads of each sample so a stall in the final sample is caught, requires
pswpoutin a storage phase, compares budgets before rounding, scales each pressure interval to one second, and writes no.readyfile when the first sample already fails.run-admitted.shuses onlyOBSERVER_OUT,--workload-cgroup auto, the.readyfile and the top-levelcleankey; those are unchanged, and a missing.readyalready means "no first sample, unit not measured" there.A second commit adds
bench/results/observer-revendor-20261106.md, a dated note.protocol-release-1.0.4.mdsays the frozenbench/code is unchanged since the freeze commit2685da5, which the observer file in the tree no longer satisfies; the note says the campaign ran thee2a593ecopy (still in git at2685da5) and lists what differs. No protocol or recorded result is edited.Checked: diff against house-rules
a4f8dd4shows only the header lines; house-rules' 31 observer tests pass against this copy;bun run checkpasses. A separate read-only review (a non-Claude model, one round) found the harness compatible and the same two documentation points, which the note answers. No benchmark was run, and nothing is released.