Repository navigation
stage-line: a trigger clause is read outside Markdown code spans - #642
Merged
Merged
Conversation
bompus
added
author:anthropic
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/in/5532859?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bompus AI Review (Gemini 4 Argon, high reasoning): 0 finding(s).
Review 2: findings below high are posted only within 3 lines of a change since d42e066.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitStage(added in #641) found thetrigger:field by excluding only atrigger:with a backtick directly before it, and ended the clause at the first;,recheck:ordone-when:anywhere. A private-reviewer point on the setupLinuxHost pin to f4bca77 said these also match inside Markdown code spans.Reproduced first: three new tests failed on the old code (a
;, arecheck:and adone-when:quoted in a code span after the realtrigger:ended the clause early; atrigger:inside a span not directly after its backtick was taken for the field). The fix blanks code spans (same length) before matching, so indices still map onto the original text, and drops the lookbehind.bun run check,bun test test/(1335 tests) andbun test skills/(1014) pass, 0 failures.Not changed: the offer-clause split of the rest of the line, which still splits on
;,,and "and" and does not read code spans.