Repository navigation
Prepare dependency review action for public release - #7
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRefactors Bomly Review into Bomly Dependency Review: updates action metadata/inputs, ref resolution and fetching with merge-base support, rebuilds CLI argument wiring, adds CI/release/scorecard workflows, repository templates and docs, and tests for refs and CLI mappings. ChangesAction Migration & Infrastructure
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
59c0de7 to
d685439
Compare
Rename public-facing action metadata and documentation for bomly-dependency-review-action. Expose the current safe bomly diff configuration surface, remove legacy alias inputs, and use PR merge-base comparisons by default. Add Marketplace branding, open-source community files, CI/release/security workflows, and focused tests for refs and CLI argument mapping.
d685439 to
997f0af
Compare
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/dependabot.yml:
- Around line 3-6: Add an npm Dependabot config alongside the existing
package-ecosystem: "github-actions" entry by adding a new block with
package-ecosystem: "npm", directory: "/", and the same schedule (interval:
"weekly"); ensure the new npm block mirrors any other settings you want (e.g.,
open-pull-requests-limit, allow/ignore rules, or security/patch update types) so
Node dependencies are automatically checked and updated in addition to GitHub
Actions.
In @.github/PULL_REQUEST_TEMPLATE.md:
- Line 1: The first heading in the pull request template uses a level-2 heading
"## Summary" which violates markdownlint MD041; change it to a level-1 heading
by replacing "## Summary" with "# Summary" (update the "Summary" heading text in
the .github PULL_REQUEST_TEMPLATE to use a single leading '#' so the file starts
with an H1).
In @.github/workflows/ci.yml:
- Line 22: Replace mutable GitHub Actions tags with immutable commit SHAs across
the workflows (ci.yml, release.yml, scorecard.yml): locate every "uses:" entry
that references mutable tags such as actions/checkout@v5, actions/setup-node@v5,
actions/upload-artifact@v4, and github/codeql-action/upload-sarif@v4 and update
each to the corresponding commit SHA for that action; ensure you leave
ossf/scorecard-action@f49aabe0b5af0936a0987cfb85d86b75731b0186 unchanged.
- Around line 21-22: Add the missing persist-credentials: false option to each
actions/checkout@v5 step named "Check out repository" in the CI and release
workflows so the GITHUB_TOKEN is not persisted to the workspace; locate each
checkout step (uses: actions/checkout@v5) in .github/workflows/ci.yml and
.github/workflows/release.yml and add the persist-credentials: false input under
that step.
In @.github/workflows/release.yml:
- Around line 90-91: The workflow is using GITHUB_SHA which can differ from the
checked-out ref in manual dispatch runs; change the tag commands to use the
repository's checked-out commit (HEAD) instead. Replace occurrences of git tag
-f "${MAJOR_TAG}" "${GITHUB_SHA}" and git push ... "refs/tags/${MAJOR_TAG}"
--force with commands that resolve the checked-out commit (e.g., git rev-parse
--verify HEAD) so use git tag -f "${MAJOR_TAG}" "$(git rev-parse --verify HEAD)"
and push that tag; ensure MAJOR_TAG is still used as the tag name.
In @.github/workflows/scorecard.yml:
- Line 11: The workflow currently uses floating action tags and a global
"permissions: read-all"; update it to pin actions to immutable commit SHAs for
actions/checkout, actions/upload-artifact, and github/codeql-action/upload-sarif
(replace actions/checkout@v5, actions/upload-artifact@v4,
github/codeql-action/upload-sarif@v4 with their corresponding @<sha> refs) and
remove or tighten the top-level "permissions: read-all" (rely on the job-level
permissions block or set minimal required permissions instead) so the workflow
uses pinned action SHAs and least-privilege permissions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4d2fa1c1-aae0-4893-afbd-4706583dc04a
⛔ Files ignored due to path filters (1)
assets/bomly-dependency-review-action-wordmark.svgis excluded by!**/*.svg
📒 Files selected for processing (25)
.github/CODEOWNERS.github/ISSUE_TEMPLATE/bug_report.yml.github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/feature_request.yml.github/PULL_REQUEST_TEMPLATE.md.github/dependabot.yml.github/workflows/ci.yml.github/workflows/release.yml.github/workflows/scorecard.ymlCODE_OF_CONDUCT.mdCONTRIBUTING.mdLICENSENOTICEREADME.mdSECURITY.mdaction.ymlpackage.jsonscripts/comment-pr.shscripts/fetch-refs.shscripts/resolve-refs.jsscripts/run-diff.shtest/fetch-refs.test.jstest/metadata.test.jstest/resolve-refs.test.jstest/run-diff.test.js
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Removed redundant block for moving major tag in release workflow.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 85-92: The "Move major tag" workflow step has inconsistent
indentation causing a YAML parse error: adjust the indentation for the entire
step (the block starting with the step named "Move major tag") to match sibling
steps (e.g., "Create or update release") so that the "name:", "env:", and "run:"
keys use the same indentation level as other steps; ensure the step's nested
keys (MAJOR_TAG, run script) are indented relative to that corrected step header
and that no line uses the extra space causing the 7-space indentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3eb510ca-078f-4c44-b008-8c7b90bac232
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/release.yml
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
Prepares the dependency review action for public release under
bomly-dev/bomly-dependency-review-action, aligns the action inputs with the current safebomly diffconfiguration surface, and fixes pull request comparisons to use the PR merge base by default.Changes
bomly-dependency-review-action.fail-on-scopes, and direct target inputs such aspath,url,container, andsbom.base-refis explicitly provided.Validation
npm run lint:shellnpm run lint:jsnpm testgit diff --checkSummary by CodeRabbit
New Features
Documentation
Configuration
Tests
Chores