Skip to content

Added floating impact minigame - #494

Open
FluffyPal0 wants to merge 1 commit into
bombsquad-community:mainfrom
FluffyPal0:main
Open

FluffyPal0 wants to merge 1 commit into
bombsquad-community:mainfrom
FluffyPal0:main

Conversation

@FluffyPal0

@FluffyPal0 FluffyPal0 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Added floating impact minigame

Implement floating impact minigame with player interactions and impact bomb mechanics.
@github-actions

Copy link
Copy Markdown

Automatic formatting/metadata could not be applied to this PR (patch touched a disallowed path, or a conflict occurred). A maintainer will need to look at this manually.

@FluffyPal0 FluffyPal0 changed the title Add floating impact minigame with impact bomb mechanics Added floating impact minigame Sep 28, 2026

@Loup-Garou911XD Loup-Garou911XD left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not call it bullet_hell instead of floating_impacts?

@Loup-Garou911XD Loup-Garou911XD left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no .py extension in file name
it must have the .py extension, and the plugman dict should have the name as file name without .py extension

Loup-Garou911XD added a commit that referenced this pull request Sep 28, 2026
The "Report metadata fixpoint status" step added in dcb50fd posts a commit
status via `gh api --method POST repos/{repo}/statuses/{sha}`, but the
permissions block was never extended to cover it. `statuses` is its own
scope and `contents: write` does not imply it, so with the block declared
the scope defaulted to `none` and every POST returned:

    gh: Resource not accessible by integration (HTTP 403)

The step then exited 1, which tripped the `if: failure()` notifier into
commenting "Automatic formatting/metadata could not be applied to this PR
(patch touched a disallowed path, or a conflict occurred)" on PRs whose
patch had in fact applied cleanly. On PR #494 both apply steps reported
success and pushed nothing, i.e. the branch was already at the fixpoint
and the step was about to report success, yet the contributor was told the
opposite.

Because the status never posted, `metadata-fixpoint` has not been set once
since it was introduced, so as a required check on main it blocks every PR.

Co-authored-by: Loup <loupg450@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants