Added floating impact minigame - #494
Open
FluffyPal0 wants to merge 1 commit into
Open
FluffyPal0 wants to merge 1 commit into
FluffyPal0 wants to merge 1 commit into
Conversation
Implement floating impact minigame with player interactions and impact bomb mechanics.
|
Automatic formatting/metadata could not be applied to this PR (patch touched a disallowed path, or a conflict occurred). A maintainer will need to look at this manually. |
Loup-Garou911XD
approved these changes
Sep 28, 2026
Loup-Garou911XD
left a comment
Member
There was a problem hiding this comment.
why not call it bullet_hell instead of floating_impacts?
Loup-Garou911XD
requested changes
Sep 28, 2026
Loup-Garou911XD
added a commit
that referenced
this pull request
Sep 28, 2026
The "Report metadata fixpoint status" step added in dcb50fd posts a commit status via `gh api --method POST repos/{repo}/statuses/{sha}`, but the permissions block was never extended to cover it. `statuses` is its own scope and `contents: write` does not imply it, so with the block declared the scope defaulted to `none` and every POST returned: gh: Resource not accessible by integration (HTTP 403) The step then exited 1, which tripped the `if: failure()` notifier into commenting "Automatic formatting/metadata could not be applied to this PR (patch touched a disallowed path, or a conflict occurred)" on PRs whose patch had in fact applied cleanly. On PR #494 both apply steps reported success and pushed nothing, i.e. the branch was already at the fixpoint and the step was about to report success, yet the contributor was told the opposite. Because the status never posted, `metadata-fixpoint` has not been set once since it was introduced, so as a required check on main it blocks every PR. Co-authored-by: Loup <loupg450@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added floating impact minigame