Repository navigation
Respect Python operator fallback for unsupported Duration operands - #30
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24. Duration's comparison/arithmetic methods raise
NotImplementedErrorfor unsupported operands, preventing Python from using the other operand's reflected method. ReturnNotImplementedinstead. Unrelated equality now returns false, custom reflected operations can participate, and unsupported arithmetic raises the standardTypeError. Existing datetime arithmetic is unchanged.All six regression cases fail before the fix. Afterward, all 382 tests pass, with 100% reported source/branch coverage in a separate coverage run. Scoped Black/Flake8, strict source mypy, and
git diff --checkpass on Python 3.12.13. The__sub__return annotation usesAnyrather than incorrectly claimingNone, retaining compatibility with the project's Python 3.7 minimum instead of importing newertypes.NotImplementedTypeat runtime.Prepared with AI assistance; Python operator fallback and existing datetime cases were verified.