Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #8. The Epson XP-345 still needs real-device verification before the issue should be closed.
MintSCAN exposes a fixed JPEG/PNG/PDF selection even when the selected eSCL source advertises only JPEG/PDF. It also sent
scan:DocumentFormatExtfor the selected MIME whenever any extension was advertised, which could send a format the source never offered. A scanner can answer unsupported ScanJobs settings with HTTP 409 while still reportingIdle.Changes
pwg:DocumentFormatandscan:DocumentFormatExtvalues before a PNG job. If formats are advertised but PNG is absent, stop with a clear message rather than sending a predictable 409 or falsely producing a.pngfile.scan:DocumentFormatExtonly when the exact selected MIME is advertised by that source.make checknow includes these tests.Verification
make checkpassed.ScannerCapabilitiesXML and the error response to identify any format/colour or extension interaction. This does not add software-side PNG transcoding for scanners without native PNG support.