Repository navigation
fix(website): meet AA contrast, stop clipping the timeline, let the figures pause - #603
Merged
Merged
Conversation
…igures pause "Get started" rendered dark text on blue (2.0:1) because .nav-links a beat .btn-primary. The Paper theme was patched on at the end of styles.css, so the button's colors move to their own rule and the patch goes. One --ok could not pass on both the light page and the dark code blocks, so code gets its own tokens. The table's Yes and No, terminal titles, comments and prompts and the skip link now meet 4.5:1. On phones five timeline buttons needed 357px of 309px and the figure hid the fifth. They wrap to 3 + 2. Both looping figures gain a pause button (WCAG 2.2.2), which stays hidden when motion is reduced because nothing loops then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An audit of katesplatform.io scored it 12/20. These are its four P1 findings. The worst: "Get started", the nav's primary button, was nearly unreadable at 2.0:1, because
.nav-links aoverrode the button's white text.What changed
--code-muted,--code-okand--code-prompt, because one--okcould not pass on both the light page and the dark blocks.--okand--nodarken for the table. The skip link is fixed too.Checks
impeccable detect: no low-contrast findings at 1280px or 390px; total findings 45 → 31 and 47 → 36.html-validate@9, as CI runs it, passes.Not tested
Emulated reduced motion, a real Tab-key walk, a real phone, and the contrast of the diagram's other two color presets.
Deliberately not done
The audit's P2s (security headers, focusable scrollers, menu keys, touch hints, fonts, image dimensions) follow in a separate PR.
Green is slightly darker on the light page, which is worth a look in the preview.