Skip to content

fix: return 200 response for unused handlers #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janvennemann wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: return 200 response for unused handlers #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f2e82b
fix: return 200 response for unused handlers
janvennemann Apr 8, 2025
578dce1
chore: adjust comment
janvennemann Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,9 @@ export async function handleWebhooks(config: WebhookRegistrationConfig, req: Req
return await _handler(evt, handlerMap[evt.type] as HandlerFn<HandlerType>)
}

// If we don't have a handler for the event, return a 404
return new Response('', { status: 404 })
// If we don't have a handler for the event, still return 200 response or else
// the Clerk will keep retrying the event
return new Response('', { status: 200 })
}

async function _handler(event: WebhookEvent, callback: Function): Promise<Response> {
Expand All @@ -176,4 +177,4 @@ async function _handler(event: WebhookEvent, callback: Function): Promise<Respon
} else {
return new Response('', { status: 200 })
}
}
}