Repository navigation
Conversation
- serial_console: keep "flash firmware <name> <size>" on the original
launcherSelectInstallLayout path; add "flash overwrite <name> <size>"
which reuses the slot a name already owns (grow/move it) instead of
prompting, so a host on the other end of a serial link never hangs.
Both share one streaming body; no extra flash cost beyond the branch.
- serial_flasher.py: opt-in --overwrite (sends "flash overwrite" and uses
windowed ACK streaming). Default stays byte-for-byte the main behavior
("flash firmware" + one-chunk-per-ack). Also survive USB-CDC
re-enumeration on reset.
- remove tools/pio_launcher_upload.py: serial_flasher covers the push.
Verified on Cardputer ADV: --overwrite creates a slot then reuses it on
re-push (single alpha0); default reproduces main's behavior.
Contributor
Author
|
As per conversation with @bmorcelli on discord, I added a bit more to PR to make size-wise, on cardputerADV, the first commit was 192 B less. Not nothing, but still within limits. I think we could shave off other things, like offloading USB stuff to a separate firmware, and it would give us a lot more room. For comparison, here are numbers I got on CarputerADV: |
konsumer
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serial
flash firmwarenow overwrites the previous slot for the same app name and fails with an ERR instead of opening the on-device menu, plus a PlatformIO extra script sopio run -t uploadpushes into Launcher.This helps facilitate pio-workflow for firmware-dev, since you can automate pushing current firmware, without wiping Launcher. We both had similar usecase in #184