Open
Conversation
…e into feature/sass_theme Conflicts: README.md
Owner
|
Thanks a lot for the contribution -- I've planned on converting to SASS for version 2.0 of Extensible, so I'm not going to merge this just yet, but I'll take a look at it when I get to that point. Should save me a lot of time, so I appreciate it! |
Author
|
Alright. That gives me the chance to refine it a little bit over time. I will try to keep this pull request up to date with any changes I see in your stylesheets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Brian,
Extensible is a very nice extension (or even more than that). For my project I needed theming support, that is why I created a SASS structure similar to the one already present in ExtJS. I saw that theming was already requested on the forum, so maybe this starting point is helpful for you or for others.
I tried naming the variables closely to their original regard and plan to separate the calendar file into more specific parts soon.
If you have any questions about how this works, just contact me.
Best regards,
Philipp
This change is