test(engine): pin hazard-first merge refusal - #821
Open
ahcrm-core wants to merge 1 commit into
Open
ahcrm-core wants to merge 1 commit into
ahcrm-core wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strengthen
test_merge_stray_dirt_escalates_with_clear_messageso it pins the hazard-first outer wording and rejects the superseded merge-mechanism wording.Closes #683
Why
The existing assertions remained green if the message regressed to saying that a merge or squash would fold the dirt into the story commit. The new assertions protect the distinction established by #618 without changing runtime behavior.
Testing
would fold themwording still passed, confirming the coverage gap.uv run pytest -q tests/test_engine_worktree.py: 287 passed.uv run ruff format --check tests/test_engine_worktree.py: passed.uv run ruff check tests/test_engine_worktree.py: passed.uv run pyright: 0 errors, 0 warnings.Test-only change; no production behavior changed.