Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Pin a retirement target for the legacy
retryvalue ofreview.on_status_contradictionand emit a load-time warning when it is selected.Why: The option is already labeled "legacy" in its own description since #334 introduced
escalateas the default, but has no version/issue owning its removal, and nothing warns an operator who is still using it. Related to #334 (closed), which establishedescalateas the default and demotedretry.How:
warnings.warn(...)whenon_status_contradiction == "retry"loads, mirroring the_fold_deprecated_enginepattern; theescalatedefault stays silent.pytest.warnstest for theretrycase and a negative test confirmingescalatetriggers no warning.Testing:
uv run pytest -q tests/test_policy.py.Changelog:
Changed: bmad-loop now warns when the legacy review.on_status_contradiction = "retry" mode is configured.🤖 Generated with Claude Code