Skip to content

fix(policy): warn when scm.max_parallel is silently clamped to 1 - #812

Draft
gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:fix/s01-13-warn-max-parallel-clamp
Draft

gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:fix/s01-13-warn-max-parallel-clamp

Conversation

@gmoncor

@gmoncor gmoncor commented Sep 17, 2026

Copy link
Copy Markdown

What: Emit an explicit warning when a configured scm.max_parallel > 1 is clamped to 1, instead of silently discarding the operator's intent.

Why: Phase 5 parallel fan-out is not built yet (tracked in #229), so the knob is inert — but nothing today tells an operator who sets max_parallel = 4 that their setting has no effect, which reads as the loop mysteriously running slower than configured. Related to #229, which this PR does not implement.

How:

  • In loads(), warn via warnings.warn(...) when requested_parallel > 1, mirroring the existing _fold_deprecated_engine warning pattern.
  • Keep the clamp behavior itself unchanged (still min(requested_parallel, 1)).
  • Add a pytest.warns test asserting the warning fires for max_parallel > 1 and that the resulting policy still clamps to 1.

Testing: uv run pytest -q tests/test_policy.py.

Changelog: Changed: bmad-loop now warns when scm.max_parallel > 1 is configured, since parallel fan-out is not yet built and the value is clamped to 1.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant