Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Pin a concrete target version (and tracking issue) for retiring the
[engine]compatibility alias, in both the code comment and the runtimeDeprecationWarningmessage.Why: The alias says it is a "one-release" compatibility shim but names no version or issue, so nothing owns its removal — it can (and likely will) outlive its intended lifetime, matching a known anti-pattern already called out in this project's own review conventions.
How:
warnings.warnmessage.#149/#156/#157convention already used elsewhere in this same file.Testing:
uv run pytest -q tests/test_policy.py— 352 passed, 2 skipped. Confirms the deprecation-warning path still matches the updated message text.Changelog:
Changed: pinned a target version for the deprecated [engine] settings block.Related to #810
🤖 Generated with Claude Code