Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Add one comment sentence to
dev_stall_nudges_capstating its safe range relative tosession_timeout_min.Why: The cap exists specifically to prevent bug #149 (a turn burned per cycle until session_timeout_min) from recurring, but nothing documents what value keeps that guarantee if
dev_stall_nudges_caporsession_timeout_minchange independently in the future. Related to #149 (closed), the original bug this cap guards against.How:
dev_stall_nudges_capnoting it should stay comfortably belowsession_timeout_min / (dev_stall_grace_s/60)so the cap fires before the timeout ceiling would anyway.Testing: Comment-only change; no behavior affected. Ran
uv run pytest -q tests/test_policy.py(352 passed, 2 skipped) to confirm no regression.Changelog: n/a (no user-visible change).
🤖 Generated with Claude Code