chore(plugins): remove the unused trusted field from LoadedPlugin

[gmoncor]

What: Remove the trusted: bool = True field from LoadedPlugin and the trusted=False kwarg passed at its one write site in registry.py, since nothing reads it anywhere in the plugins package.

Why: A repo-wide search of .trusted accesses in src/bmad_loop/plugins/ finds only the one write site and zero reads; real trust decisions already use lp.instance is not None and lp.manifest.python is None. The field is dead and could mislead a future reader into believing it gates something.

How:

• Delete the trusted field from the LoadedPlugin dataclass in model.py.
• Delete the trusted=False kwarg at its construction site in registry.py's _resolve.

Testing: Run the existing plugins pytest suite to confirm no test references .trusted; if one does, update it in this same PR. (Three assertions in tests/test_plugin_trust.py and tests/test_plugin_workflows.py did reference .trusted and were updated to assert on the real trust signals instead: lp.instance and lp.manifest.python.)

Changelog: Removed - Remove the unused trusted field from LoadedPlugin and the trusted=False kwarg passed at its one write site in registry.py, since nothing reads it anywhere in the plugins package.

Related to #496 (plugins/trust.py::require_enabled name-gate and plugins/loader.py overlay precedence) — same subsystem, different defect; not affected by this dead-code removal.

🤖 Generated with Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}