Skip to content

Remove legacy review.on_status_contradiction = "retry" mode #813

Description

@gmoncor

The retry value of review.on_status_contradiction (ReviewPolicy.on_status_contradiction, src/bmad_loop/policy.py) is documented as "legacy" in both core.toml's field description and the policy docstring, since #334 introduced escalate as the default and demoted retry to a compatibility fallback. Until now it named no concrete removal target and emitted no load-time warning.

This issue is the tracking/ownership point for actually removing the retry value from REVIEW_ON_STATUS_CONTRADICTION_MODES and its handling, targeted for version 0.12.0.

Acceptance criteria

  • retry is removed from REVIEW_ON_STATUS_CONTRADICTION_MODES and ReviewPolicy.on_status_contradiction in src/bmad_loop/policy.py.
  • Any remaining docs/tests referencing retry for this field are updated to escalate.
  • Released as part of, or after, version 0.12.0.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Robustness, enhancement, tests, or docs worth schedulingarea:configBMAD config resolution and the setup skillenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions