docs: redesign walkthrough pipeline map and clarify execution boundaries - #156
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 58 seconds. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: bmad-code-org/bmad-eval-quality/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
muratkeremozcan
force-pushed
the
docs/walkthrough-pipeline-redesign
branch
from
September 22, 2026 15:39
18183b7 to
f1acc9d
Compare
muratkeremozcan
changed the base branch from
main
to
docs/retire-what-ships-and-clarify-contract-strength
September 22, 2026 15:39
muratkeremozcan
force-pushed
the
docs/walkthrough-pipeline-redesign
branch
from
September 22, 2026 15:55
f1acc9d to
bbfef55
Compare
muratkeremozcan
added this pull request to stack #157
September 22, 2026 15:59
Base automatically changed from
docs/retire-what-ships-and-clarify-contract-strength
to
main
September 22, 2026 16:01
- Replace competing conceptual diagrams with ONE canonical numbered pipeline map matching sections 1 through 7. - Visibly distinguish executed CLI stages from read-only inspection sections. - Add explicit callouts for caller/harness execution boundaries and the two skipped execution gaps (preflight active probing and SUT/evaluator execution). - Rename Step 5 to 'Reduce the preflight observations' and clarify that the CLI command executes preflightFromObservations over prepared fixtures. - Rename Step 6 to 'Score the evaluation record' and make explicit that score evaluates prepared evidence from a prior run. - Update the artifact map to distinguish newly minted artifacts from replayed prepared fixtures. - Update summary flow in key takeaways to mirror the numbered pipeline.
…rison advice, and replay consistency
muratkeremozcan
force-pushed
the
docs/walkthrough-pipeline-redesign
branch
from
September 22, 2026 16:01
bbfef55 to
a15b56d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR redesigns
docs/how-to/author-behavioral-contracts.mdaround a single, canonical numbered pipeline map that maps directly to the seven numbered walkthrough sections:Unified Pipeline Map:
compile,seal,preflight,score) from read-only inspection sections (Steps 2, 3, 7).Explicit Execution Boundaries & Skipped Gaps:
eval-qualityCLI owns deterministic offline transformation/reduction, while the caller's evaluation harness owns dynamic environment and evaluator execution.preflightFromObservationsover preparedobservations.jsonandprobes.json. Explained that programmatic use with the TypeScript SDK can drive a liveEnvironmentProbePortviarunPreflight.scorereplays the preparedsealed-run-record.jsonfixture.Section Headings & Descriptions:
Preflight the environmenttoReduce the preflight observations, clearly explaining that this step reduces prepared observations to aPreflightVerdict.Score the evaluation recordand clarified that it evaluates the prepared run record against the probe.Verification
npm run docs:validate-links: 0 broken links.node scripts/check-docs.mjs: All files pass.node scripts/gates-cli.ts doc-invocations: 0 failures (54 run faithfully, 14 compared).node scripts/gates-cli.ts doc-counts: 42 numerals across 11 files, 0 disagreements.node scripts/gates-cli.ts doc-claims: 0 disagreements.vitest run tests/architecture/doc-gates.test.ts: 47/47 passing.node tools/build-docs.mjs: Clean build (17 pages generated).