Skip to content

fix(installer): display declared versions for custom modules - #2910

Open
lorenzozanee wants to merge 1 commit into
bmad-code-org:V6.12from
lorenzozanee:fix/custom-module-version
Open

lorenzozanee wants to merge 1 commit into
bmad-code-org:V6.12from
lorenzozanee:fix/custom-module-version

Conversation

@lorenzozanee

@lorenzozanee lorenzozanee commented Sep 18, 2026

Copy link
Copy Markdown

What

Display the declared version for unpinned Git custom modules in installer status and generated manifests.

Why

Unpinned custom modules were reported as main even when marketplace metadata declared a version.

Fixes #2907

How

  • Prefer the resolved module version after an explicit cloned ref.
  • Keep main as the fallback when no version metadata is available.
  • Add regression coverage for the marketplace version path.

Testing

Passed node test/test-installation-components.js (496 tests), node test/test-installer-channels.js (83 tests), changed-file Prettier and ESLint checks, and git diff --check.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the fallback change matching the installer’s existing metadata-resolution semantics and focused regression coverage.

Summary

This PR corrects custom-module version reporting by preferring resolved version metadata before falling back to main for unpinned Git modules.

  • Updates custom-module manifest version selection while preserving explicit clone refs as the highest priority.
  • Adds regression coverage for versions declared in marketplace metadata.

Reviews (1) · Last reviewed commit: "fix(installer): preserve custom module v..."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant