Skip to content

fix: resolve local custom modules during quick update - #2906

Open
lorenzozanee wants to merge 1 commit into
bmad-code-org:V6.12from
lorenzozanee:fix/forward-bmad-dir
Open

lorenzozanee wants to merge 1 commit into
bmad-code-org:V6.12from
lorenzozanee:fix/forward-bmad-dir

Conversation

@lorenzozanee

Copy link
Copy Markdown

What

Forward the existing bmadDir into OfficialModules source lookup so manifest-backed local custom modules can be refreshed during quick-update.

Why

The availability check could identify a local custom module, but installation lost the manifest directory and reported that its source was unavailable.
Fixes #2869

How

  • Pass bmadDir through the existing source lookup options.
  • Add an installation-component regression test for a manifest-backed local module.

Testing

Validated with npm test, npm run quality, npm run format:check, npm run lint, and git diff --check.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the intended quick-update source-resolution path covered by a focused regression test.

Summary

This PR fixes quick updates for manifest-backed local custom modules by preserving the installation directory through source resolution.

  • Forwards bmadDir from OfficialModules.install into custom-module source lookup.
  • Adds a regression test proving that a manifest localPath is resolved and copied into the installation target.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Quick update] --> B[Installer.install]
    B --> C[OfficialModules.install]
    C -->|bmadDir| D[findModuleSource]
    D --> E[CustomModuleManager.findModuleSourceByCode]
    E --> F[Read installed manifest]
    F --> G[Resolve localPath]
    G --> H[Copy local module into bmadDir]
Loading

Reviews (1) · Last reviewed commit: "fix: forward bmad directory during modul..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant