Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Extend parse_orderable_semver's exclusion check to also treat "-next" as non-orderable, alongside the existing "-dev" check.
Why: Every packaged module-manifest.toml currently sets version = "6.13.0-next" as a moving-target placeholder tag exactly like -dev; without this fix, comparisons involving -next can behave inconsistently with the repo's own -dev handling.
How:
Testing: Ran tools/tests/test_bmad_setup.py; new assertion fails before the fix and passes after. Ran the full suite before/after on this Windows checkout and diffed the failing-test sets: identical (56 preexisting, all Windows-environment-specific: path separators, symlinks, CRLF, chmod/atomic-write) -- no new or fixed failures either direction.
🤖 Generated with Claude Code