Conversation
1e8f4b2 to
1ba6fbd
Compare
…ases
The two new reserved-module-render cases called a helper
(dump_manifest_toml) that does not exist in this test file and used
'module' instead of 'code' as the field key, so the whole containing
test method raised NameError before running. Switched both cases to
dump_bmod_toml(bmod={...}), matching the sibling
case-insensitive-reserved-module case right above them.
|
@coderabbitai review |
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: bmad-code-org/BMAD-METHOD/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe setup script now treats ChangesBmod validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The reservation and its tests align with the intended collision prevention; no actionable merge risk remains after normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What: Add "render" to RESERVED_MODULE_DIRS in setup.py so a packaged module cannot use that name.
Why: render_skill.py writes its content-addressed snapshot to _bmad/render//-, at the same tree level as installed modules; a module literally named render would collide with that directory, and no existing reserved-name guard covers it.
How:
Testing: Ran tools/tests/test_bmad_setup.py; the new case fails before the fix and passes after (ablation-check by temporarily removing the frozenset entry).
🤖 Generated with Claude Code