chore(qa-e2e): remove dead variables, redundant resolve call, and fix invocation wording

[gmoncor]

What: Three small, independent hygiene fixes bundled because they land in the same short file: (1) change "use the bmad-code-review skill" to "invoke the bmad-code-review skill"; (2) delete the unused test_dir and source_dir declarations; (3) replace the redundant On-Complete resolve_customization.py re-invocation with a direct reference to the value already resolved in Step 1.

Why: Wrong verb per the repo's REF-03 invocation-language convention; test_dir/source_dir have zero consumers anywhere in the file; re-running resolve_customization.py for workflow.on_complete duplicates work already done in Step 1.

How:

• Line ~10: "use" -> "invoke".
• Paths section: delete test_dir and source_dir, keep default_output_file.
• On Complete section: reference {workflow.on_complete} directly instead of re-invoking the script.

Testing: Read-through diff confirming default_output_file is still referenced later and no remaining reference to test_dir/source_dir; prompt-text-only change.

🤖 Generated with Claude Code

[github-actions]

@coderabbitai review

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or repository-rule violations identified.

Summary

This PR performs three safe hygiene updates to the QA E2E test-generation skill:

• Uses the repository-standard invocation wording for bmad-code-review.
• Removes two unused path variables.
• Reuses the customization value resolved during activation instead of invoking the resolver again.

_{Reviews (1) · Last reviewed commit: "chore(qa-e2e): remove dead variables, re..."}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: bmad-code-org/BMAD-METHOD/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8ce8a08d-11ff-409f-bef3-5f4202ff10a6

📥 Commits

Reviewing files that changed from the base of the PR and between 1b59caa and a5d4e1b.

📒 Files selected for processing (1)

• skills/bmad-qa-generate-e2e-tests/SKILL.md

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.

---

📝 Walkthrough

Walkthrough

The QA E2E test skill now uses updated role wording, omits the test_dir and source_dir paths, and directly follows the configured workflow.on_complete value when it is non-empty.

Changes

QA E2E test skill

Layer / File(s)	Summary
Update skill instructions skills/bmad-qa-generate-e2e-tests/SKILL.md	The role description now says to invoke the bmad-code-review skill. The test_dir and source_dir path definitions were removed. The on-complete instruction now uses {workflow.on_complete} directly; its conditional behavior is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: alexeyv

Merge Risk: ⚪ Minimal · up to a5d4e

The skill uses its loaded completion setting and removes unused path entries. No material behavior risk is established, so the change is ready for normal checks.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the three hygiene changes in the pull request: removing unused variables, eliminating a redundant resolve call, and correcting invocation wording.
Description check	✅ Passed	The description directly explains the wording change, variable removal, redundant call removal, rationale, implementation details, and testing performed.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}