Repository navigation
fix: remove the Silo description Translate button - #306
Conversation
The Translate button under the synopsis was partly covered by the cast line on Apple TV. Vivid no longer offers Silo's on-view description translation on iPhone, iPad or Apple TV, in either its button or automatic mode, and no longer asks a Silo server whether it translates descriptions. Descriptions still come back in the profile's metadata language, which Silo translates on the server. The privacy policy, the in-app privacy text and the App Review notes no longer mention translated descriptions.
There was a problem hiding this comment.
Claude review of the whole PR at 28616db. The summary comment lists everything found.
|
Claude review of the new commits 23607fd..328bd28 I reviewed the changes since 23607fd: the reordered AI sentence in the iPhone and Apple TV privacy texts (IOSSettingsOverview.swift, TVSettingsComponents.swift) and the reworded placeholder comment in TVDetailHeroPanel.swift. The AI sentence now follows the server logs sentence, so "that information" points back at the device details, and the comment now describes the placeholder accurately. The privacy paragraphs aren't keyed in the String Catalog, so the reorder loses no translations. Nothing needs fixing. I didn't build the app or run any tests. I checked the two new changes since 23607fd: the reworded placeholder comment in TVDetailHeroPanel.swift and the reordered AI sentence in the iPhone/iPad and Apple TV privacy texts. The comment now matches what the zero-size view does. "That information" again follows the device-identification sentence. The AI wording is the same in the in-app texts and website/public/privacy.html. The reordered strings aren't keys in Localizable.xcstrings, so the String Catalog needs no update. Nothing needs fixing. claude-sonnet-5-5, high effort, 6 turns, about US$0.11 of API credit |
There was a problem hiding this comment.
All reported issues were addressed across 26 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
…cing publishRefetchedDetail, keepingPlayback and DetailTranslationPublishTests only served the removed Translate button. A zero-size placeholder stays where the hidden button sat on iPhone, iPad and the Apple TV standard hero, so the stacks keep the spacing they had.
A local package resolve rewrote it and it was committed by mistake.
Problem and reproduction
A tester on TestFlight 1.1 (8), Apple TV 4K (3rd generation), tvOS 27.0, on a Silo server, reported that the Translate button under the synopsis is partly hidden behind the cast line below it, on every movie and series.
The button is Silo's on-view description translation.
It only shows when the Silo server has AI metadata on with its on-view mode set to a button, and the title's description isn't in the viewer's metadata language yet.
On the Apple TV movie and series pages the synopsis and the button share a fixed 140 point area, the synopsis takes 112 of it, and the button doesn't fit in what's left.
I decided to remove the feature from Vivid rather than make room for it.
Implementation and impact
/api/v1/metadata/ai/status, and its v2 route), and thetranslate-descriptioncall.pendingTranslationLanguagefield from the item model. The server can still send it and it is ignored.publishRefetchedDetail,keepingPlaybackandDetailTranslationPublishTests, which only served the button.Silo only. Emby and Jellyfin never showed the button and are unchanged.
Descriptions still come back in the profile's metadata language, which Silo translates on the server. That setting is unchanged.
Anyone who relied on the button loses it. A title whose description hasn't been translated on the server now just shows the description the server returns.
Validation
xcodebuild buildofVividTVfor an Apple TV 4K (3rd generation) simulator andVividfor an iPhone 18 Pro simulator, both ad hoc signed: both succeeded.python3 scripts/ci/check-docs.py --base origin/main: passes.AIModelDecodingTestsandDetailTranslationPublishTests, which only tested deleted code. No tests added.Performance
Not applicable, no performance claim. No benchmark was run. Vivid makes one less request to a Silo server at sign-in and on each foreground.
Testing status
Design impact and approval
Documentation impact
website/public/privacy.htmland the in-app privacy text: removed the translated descriptions sentence, kept the AI service sentence and updated the date.docs/release/distribution.md: removed translated descriptions from the review server setup and the App Review notes.docs/cores/silo.md: says Vivid doesn't offer Silo's on-view description translation.String Catalog synced: "Translate", "Translating…" and the old privacy date are marked stale, and the new date carries its translations over.
I checked the docs this change affects and updated them in this PR, or explained above why none needed changes.
AI disclosure
I implemented these changes and used Claude Fable 5.2 as a tool.