Repository navigation
fix: show the notch tab bar in the Apple TV Tab Bar settings preview - #305
Conversation
The preview in General > Customise Tab Bar still drew the old capsule with text tabs. It now draws the bar's own notch with the same views and plays it on a loop: it opens, moves to the next tab, chooses it and closes around it. With Reduce Motion it stays open on one tab. The bar's tab, Search, avatar, divider and highlight drawing moved into shared views so the bar and the preview stay in step.
There was a problem hiding this comment.
Claude review of the whole PR at 558379a. The summary comment lists everything found.
|
Claude review of the new commits 558379a..003c6b2 I reviewed the new commit, 003c6b2, covering I checked the changes since 558379a against the code and docs. The single-tab guard in claude-sonnet-5-5, high effort, 8 turns, about US$0.09 of API credit |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Problem and reproduction
On Apple TV, Settings > General > Customise Tab Bar has a preview of the tab bar at the top.
After #302 moved the real bar to a notch with symbol tabs, the preview still drew the old floating capsule with every tab as text and Home as a white pill, so it no longer looked like the bar it was previewing.
The preview was a separate hand-drawn copy of the bar, which is why it was missed.
Implementation and impact
TopBarinto shared views (TVTopMenuTabLabeland friends) that both the bar and the preview use. The real bar's focus handling, timing and layout are otherwise unchanged.Apple TV only. No provider code is touched, and iPhone and iPad are unchanged.
The main risk is the refactor of the real bar's drawing into shared views. It is meant to be a straight move with no behaviour change.
Validation
xcodebuild build -project Vivid.xcodeproj -scheme VividTVfor an Apple TV 4K (3rd generation) simulator on tvOS 27.0: succeeded.Performance
Not applicable, no performance claim. No benchmark was run.
Testing status
Design impact and approval
Documentation impact
Updated
docs/apple-tv-browsing.mdto describe the new preview.AI disclosure
I implemented these changes and used Claude Fable 5.2 as a tool.