Open
Conversation
Forbidding in-source builds makes it harder to integrate with existing firmware build systems like Buildroot. Signed-off-by: Jakov Petrina <jakov.petrina@byte-lab.com>
This makes it possible to install the library and public includes using standard commands. For example: $ DESTDIR=./rootfs cmake --install ./build/ --prefix '/usr' -- Install configuration: "" -- Installing: ./rootfs/usr/lib/libnote_c.so -- Installing: ./rootfs/usr/include/note-c/n_cjson.h -- Installing: ./rootfs/usr/include/note-c/note.h Signed-off-by: Jakov Petrina <jakov.petrina@byte-lab.com>
This fixes x86-specific arguments being set for non-x86 platforms, allowing cross-compilation. Signed-off-by: Jakov Petrina <jakov.petrina@byte-lab.com>
Contributor
|
Thanks for bringing this up! I just saw this, and haven't had a chance to properly review it. I definitely want to support as many folks as possible, and I'm happy to introduce the flexibility required to make that happen. Let me grok what you've done, and I'll provide some feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
one of our customers has an non-x86 Linux target and we needed to change a few things in the build system to make this library integrate well with e.g. firmware build systems like Buildroot and to support cross-compilation.
For example, it is great help for us to do:
and it Just Works™.
I'm using this PR as an opportunity to open the discussion and contribute upstream; let me know if you'd like some changes, thanks!
cc @spahijajakov @PL4typus