Skip to content

Fontend: fix display size of images on extension readmes#3836

Merged
Williangalvani merged 1 commit intobluerobotics:masterfrom
Williangalvani:readme_size
Mar 19, 2026
Merged

Fontend: fix display size of images on extension readmes#3836
Williangalvani merged 1 commit intobluerobotics:masterfrom
Williangalvani:readme_size

Conversation

@Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Mar 19, 2026

Screenshot 2026-03-19 at 12 41 02

fix #3832

Summary by Sourcery

Bug Fixes:

  • Prevent extension README images from exceeding the modal width by limiting their maximum displayed width.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a CSS rule to constrain images in the extension readme section so they do not exceed the container width, improving display across different viewport sizes.

File-Level Changes

Change Details Files
Constrain extension readme images to the container width.
  • Add a CSS selector targeting images inside the readme container.
  • Set max-width to 100% so images scale down responsively instead of overflowing.
core/frontend/src/components/kraken/modals/ExtensionDetailsModal.vue

Assessment against linked issues

Issue Objective Addressed Explanation
#3832 Constrain images in the extension readme/description so that large images do not overflow the page or modal width.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider explicitly setting height: auto; on div.readme img to avoid potential image distortion when images come with fixed height attributes from markdown or external sources.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider explicitly setting `height: auto;` on `div.readme img` to avoid potential image distortion when images come with fixed height attributes from markdown or external sources.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@Williangalvani Williangalvani merged commit e0a32b9 into bluerobotics:master Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Big images in the extension description are overflowing the page size

2 participants