Skip to content

Frontend: add Homepage to extensions modal#3835

Merged
Williangalvani merged 1 commit intobluerobotics:masterfrom
Williangalvani:homepage
Mar 19, 2026
Merged

Frontend: add Homepage to extensions modal#3835
Williangalvani merged 1 commit intobluerobotics:masterfrom
Williangalvani:homepage

Conversation

@Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Mar 19, 2026

I don't think I like the way this looks. feedback is appreciated

image

fix #3834

Summary by Sourcery

Add extension homepage and improved author contact display to the extensions details modal.

New Features:

  • Display an extension homepage link in the details modal when a website URL is available.

Enhancements:

  • Show authors in the extension details modal with icons and mailto links instead of a plain text list.
  • Extend the extension data type to include an optional website field used by the UI.

Summary by Sourcery

Add support for displaying an extension homepage link in the extension details modal.

New Features:

  • Show a homepage button in the extension details modal when an extension provides a website URL.

Enhancements:

  • Extend the extension metadata type to include an optional website field used by the UI.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds support for an optional extension homepage URL and exposes it in the Extension Details modal via an icon button, while extending the ExtensionData type to include the new website field.

Updated class diagram for ExtensionData with optional website

classDiagram
  class ExtensionData {
    string id
    string name
    string version
    string description
    string author
    string company_logo
    string extension_logo
    boolean is_compatible
    string website
  }

  note for ExtensionData "website is optional and used to render the Homepage button in ExtensionDetailsModal"
Loading

File-Level Changes

Change Details Files
Expose an extension homepage link in the Extension Details modal when available.
  • Render a homepage icon button in the modal header if the extension has a website URL.
  • Wire the button to open the homepage in a new tab with appropriate security-related rel attributes.
  • Attach a tooltip label to clarify the button purpose.
core/frontend/src/components/kraken/modals/ExtensionDetailsModal.vue
Extend the extension metadata model to carry an optional website URL used by the UI.
  • Add an optional website field to the ExtensionData interface so the frontend can safely reference extension.website.
core/frontend/src/types/kraken.ts

Assessment against linked issues

Issue Objective Addressed Explanation
#3834 Expose a visible link to an extension's website in the extension store UI whenever the website URL is present in the manifest.
#3834 Extend the extension data model to include a website field sourced from the manifest so it can be used by the frontend.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Williangalvani Williangalvani force-pushed the homepage branch 2 times, most recently from 9fc0429 to 16c2284 Compare March 19, 2026 15:47
@Williangalvani Williangalvani marked this pull request as ready for review March 19, 2026 15:51
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • For accessibility, consider adding an explicit aria-label on the icon button (e.g., aria-label="Homepage") so screen readers don’t rely solely on the tooltip.
  • Since the website URL comes from extension data, it may be worth normalizing/validating it before binding to :href to avoid malformed or unsafe URLs being rendered as links.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For accessibility, consider adding an explicit aria-label on the icon button (e.g., aria-label="Homepage") so screen readers don’t rely solely on the tooltip.
- Since the website URL comes from extension data, it may be worth normalizing/validating it before binding to :href to avoid malformed or unsafe URLs being rendered as links.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rafaellehmkuhl
Copy link
Member

Nice! That will help!

@Williangalvani Williangalvani merged commit 7fd7ffd into bluerobotics:master Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension cards in the store could show a link to the extension website

2 participants