Frontend: add Homepage to extensions modal#3835
Merged
Williangalvani merged 1 commit intobluerobotics:masterfrom Mar 19, 2026
Merged
Frontend: add Homepage to extensions modal#3835Williangalvani merged 1 commit intobluerobotics:masterfrom
Williangalvani merged 1 commit intobluerobotics:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds support for an optional extension homepage URL and exposes it in the Extension Details modal via an icon button, while extending the ExtensionData type to include the new website field. Updated class diagram for ExtensionData with optional websiteclassDiagram
class ExtensionData {
string id
string name
string version
string description
string author
string company_logo
string extension_logo
boolean is_compatible
string website
}
note for ExtensionData "website is optional and used to render the Homepage button in ExtensionDetailsModal"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
9fc0429 to
16c2284
Compare
16c2284 to
105c23b
Compare
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For accessibility, consider adding an explicit aria-label on the icon button (e.g., aria-label="Homepage") so screen readers don’t rely solely on the tooltip.
- Since the website URL comes from extension data, it may be worth normalizing/validating it before binding to :href to avoid malformed or unsafe URLs being rendered as links.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For accessibility, consider adding an explicit aria-label on the icon button (e.g., aria-label="Homepage") so screen readers don’t rely solely on the tooltip.
- Since the website URL comes from extension data, it may be worth normalizing/validating it before binding to :href to avoid malformed or unsafe URLs being rendered as links.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
rafaellehmkuhl
approved these changes
Mar 19, 2026
Member
|
Nice! That will help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think I like the way this looks. feedback is appreciated
fix #3834
Summary by Sourcery
Add extension homepage and improved author contact display to the extensions details modal.
New Features:
Enhancements:
Summary by Sourcery
Add support for displaying an extension homepage link in the extension details modal.
New Features:
Enhancements: