gcache with context

[dragonsinth]

No description provided.

[greyireland]

update readme

[alexanderbolgov-ef]

would be great to have this change merged

[romansonrai]

No tests for Context timeout/Context related functionality

[dragonsinth]

I didn't see a compelling need; the functional changes are almost nothing; it's mostly just plumbing ctx around everywhere.

[romansonrai]

For the most part I certainly agree with you, but the changes in singleflight.go (Do function) are comparatively substantial. And that would be the only place I would include additional tests.

[dragonsinth]

Fair enough. But worth noting that this PR has grown stale and needs rebase+conflict res. I'm not inclined to keep working on this PR without some indication that there's a path to getting this merged.

[romansonrai]

Yes, I agree….looks like the owner ditched the project…in any case, I love the code and the use case is a very common one.

…

On Feb 21, 2023, at 2:30 PM, Scott Blum ***@***.***> wrote: Fair enough. But worth noting that this PR has grown stale and needs rebase+conflict res. I'm not inclined to keep working on this PR without some indication that there's a path to getting this merged. — Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4FXSSOJKACVOP7S7VAHVO3WYUCSXANCNFSM4HZC2FCA>. You are receiving this because you commented.