feat: add config file support to configure docker images#92
feat: add config file support to configure docker images#92KatyaRyazantseva wants to merge 9 commits intoblockblaz:mainfrom
Conversation
|
instead of adding it as a extra flag why don't we make it madatory for network folders (local-network, ansible-network) to have a clients-config.yaml file where this can be specified and read from? also remove individual images reads from client cmds, so its not an override but the original place to specify |
The idea behind this custom parameter was to switch to a new image (for local testing) without having to change the client-cmd.sh. |
The long-term goal is to make quickstart possible to run just by pulling the docker image. In this case, we won't have the whole repo available and will need to pass the config file as a parameter. Additionally, the config file may have a custom name and path depending on the user's setup. Additionally, I'm not a fan of having two separate config files. I would prefer to refactor this (either now or later) into a single file that maintains the separation through structure, for example: This approach would use corresponding defaults for each section. Whenever users need to change something on the local or ansible side, they can configure it in one file without duplicating other parameters. |
Adds a configuration file system to customize Docker images for lean clients without modifying the codebase.
Related to #83
Key changes:
--config-fileflag to specify custom image overridesclient-cmds/default-client-config.ymluser-config.yml.exampleload-client-config.shUsage:
# Use custom images NETWORK_DIR=local-devnet ./spin-node.sh --node all --config-file user-config.yml Only override specific clients from the config file - others use defaults automatically.