Add --docker-image flag to override default client Docker images#86
Open
ch4r10t33r wants to merge 6 commits intomainfrom
Open
Add --docker-image flag to override default client Docker images#86ch4r10t33r wants to merge 6 commits intomainfrom
--docker-image flag to override default client Docker images#86ch4r10t33r wants to merge 6 commits intomainfrom
Conversation
Member
|
why can't it be done by editing the client cmd file? don't wanna blow up the flags |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--docker-imageflag to override default client Docker imagesSummary
This PR adds support for the
--docker-imagecommand-line parameter tospin-node.sh, allowing users to override the default Docker image for client nodes without modifying tracked files inclient-cmds/*-cmd.sh. This addresses issue #83.Problem
Previously, updating client Docker images or flags required modifying
client-cmds/*-cmd.shfiles, which:Solution
Added a new
--docker-image <image[:tag]>parameter that:node_dockercommand before execution