Remove agent creation success modal - #5063
Conversation
Signed-off-by: kenny lopez <klopez4212@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 579710a947
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (created.spawnError || !targetChannel) { | ||
| toast.success("Agent created"); |
There was a problem hiding this comment.
When a creation launched through RequestedAgentCreateDialogs returns spawnError, this branch emits only the success toast; usePersonaActions.handleSubmit stores the failure in that hook instance's personaErrorMessage, but the contextual component never renders that state and closes the dialog after the handler returns. The user is therefore told only “Agent created” even though the agent did not start, whereas the removed modal previously displayed the spawn error; include the failure in the toast or keep a rendered error surface.
Useful? React with 👍 / 👎.
| const id = toast.warning("Agent created", { | ||
| description: `${created.agent.name} couldn’t be added to #${targetChannel.name}. ${error}`, | ||
| id: toastId, | ||
| action: { |
There was a problem hiding this comment.
When the initial channel attachment fails, all retry state now exists only in this Sonner toast, which uses the default short lifetime because no duration is supplied. If the user does not click “Try again” before it disappears—for example while reading the relay error or while the app is backgrounded—the targeted retry is lost, unlike the previous modal that remained until dismissal; make the failure toast persistent or retain the retry elsewhere.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation