fix(pairing): preserve public relay URL in QR auth - #5033
Open
kn8-codes wants to merge 1 commit into
Open
Conversation
Signed-off-by: kn8@theecodepoet.dev <0x0sec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes path-based public HTTPS/WSS pairing proxies where the mobile client signs the scanned public relay URL while the upstream relay derives a different internal tenant origin.
Validation
git diff --checkcargo fmt --checkcargo test -p buzz-relay nip42_acceptable_relay_urls_includes_configured_pairing_relay_urlcargo check --manifest-path desktop/src-tauri/Cargo.tomlAll listed checks passed.
just ciwas started but exceeded the local ten-minute execution limit while the broad desktop suite was still running. It did not report a failing assertion before timeout; it is not represented as a completed full-CI pass.