fix(desktop): refresh overlapping profile batches - #5028
Open
PrimePattern wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ultron Prime <noreply@github.com>
PrimePattern
force-pushed
the
mason/dm-sidebar-profile-metadata
branch
from
August 6, 2026 09:39
64cfc91 to
dccd6f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
users-batchqueries synchronized when another batch key refreshes the same profileRoot cause
The sidebar's aggregate profile query could retain an older empty/missing result while a different
users-batchquery successfully refreshed the same people. The fresh result populated the relay-scoped label cache and per-pubkey cache, but did not update already-mounted aggregate observers, so DM rows stayed on pubkey fallbacks until remount/refetch.Verification
pnpm checkpnpm test— 4,389 passed, 0 failedpnpm buildOriginated from Buzz channel
1aa20aee-df60-40f4-81c4-16a6bda270ce, threadefa9990b62a934907adfdd0c100c026b06c8c677afe6608458c7b88c0f14653a.