Skip to content

test(desktop): await thread scroll anchor #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 2 commits into from
Aug 6, 2026
+30 −14
Merged

test(desktop): await thread scroll anchor #3174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f89a41
test(desktop): await thread scroll anchor
Jul 27, 2026
a5b396d
Merge branch 'main' into grumplestiltzkin/thread-focus-scroll-flake
wesbillman Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions desktop/tests/e2e/thread-focus-mode.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,37 @@ async function seedLongThread(page: import("@playwright/test").Page) {
});
}

async function topVisibleMessageId(
async function scrollToMiddleVisibleMessage(
body: import("@playwright/test").Locator,
threadRootId: string,
): Promise<string> {
return body.evaluate((element) => {
const top = element.getBoundingClientRect().top;
const row = Array.from(
element.querySelectorAll<HTMLElement>("[data-message-id]"),
).find((candidate) => candidate.getBoundingClientRect().bottom > top);
if (!row?.dataset.messageId) throw new Error("No visible thread anchor");
return row.dataset.messageId;
});
let anchorId: string | null = null;
await expect
.poll(async () => {
anchorId = await body.evaluate((element) => {
const maxScrollTop = element.scrollHeight - element.clientHeight;
if (maxScrollTop <= 0) return null;

const targetScrollTop = Math.floor(maxScrollTop * 0.4);
element.scrollTop = targetScrollTop;
element.dispatchEvent(new Event("scroll", { bubbles: true }));

if (Math.abs(element.scrollTop - targetScrollTop) > 1) return null;
const bounds = element.getBoundingClientRect();
const row = Array.from(
element.querySelectorAll<HTMLElement>("[data-message-id]"),
).find((candidate) => {
const rect = candidate.getBoundingClientRect();
return rect.bottom > bounds.top && rect.top < bounds.bottom;
});
return row?.dataset.messageId ?? null;
});
return anchorId !== null && anchorId !== threadRootId;
})
.toBe(true);

if (!anchorId) throw new Error("No visible middle-thread anchor");
return anchorId;
}

/**
Expand Down Expand Up @@ -181,11 +201,7 @@ test("focus and split preserve reading context and interaction ownership", async
.toBe(true);
await expect(channel).toHaveAttribute("inert", "");

await body.evaluate((element) => {
element.scrollTop = element.scrollHeight * 0.4;
element.dispatchEvent(new Event("scroll", { bubbles: true }));
});
const anchorId = await topVisibleMessageId(body);
const anchorId = await scrollToMiddleVisibleMessage(body, rootId);

const focusModeToggle = page.getByRole("button", {
name: "Show thread beside channel",
Expand Down
Loading