Repository navigation
fix(github): open Command-clicked panel links in the browser - #3474
Draft
joshfriend wants to merge 1 commit into
Draft
joshfriend wants to merge 1 commit into
joshfriend wants to merge 1 commit into
Conversation
Tauri's automatic link opener skips Command-clicks, so Command-clicking the pull request title, repository, checks or any other link in the GitHub panel did nothing. Send those clicks through the opener, as message links already do. Signed-off-by: Josh Friend <jfriend@block.xyz>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command-clicking a link inside the GitHub panel (the pull request title, owner, repository, checks, files or body links) did nothing on desktop, because Tauri's automatic link opener deliberately skips Command-clicks. Message links already route Command-clicks through the opener (#2288), but the panel never did, so there was no way to jump from the panel to the browser with the usual gesture. The panel now delegates Command-clicks on its http(s) links to the opener, and plain clicks stay with Tauri's own handling. A new GitHubPanel test covers both and fails without the fix; the GitHub plugin tests, typecheck and biome pass.