Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Kevin Chung <chung@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
channel-completion.spec.mjscan fail withpage.goto: Timeout 15000ms exceeded. Each test starts its own Vite dev server, and a busy CI shard cannot load about 1,600 modules in time (example failure). #2776 fixed the same problem formentions.spec.mjs.Description
Build
tests/fixtures/mentions.htmlonce and serve the bundle to both tests, asmentions.spec.mjsdoes.Changes
beforeAllbuilds the page into a temp directory and serves it withpreview.afterAllcloses the server and removes the directory.try/finallyblocks are gone. No assertions or timeouts change.Testing
Chromium and WebKit pass the full file, and each passes 10 of 10 with
--repeat-each=5. No browser cases are added or removed.